Will-Lo commented on code in PR #3640:
URL: https://github.com/apache/gobblin/pull/3640#discussion_r1114672807
##########
gobblin-runtime/src/main/java/org/apache/gobblin/runtime/spec_store/MysqlBaseSpecStore.java:
##########
@@ -72,6 +73,7 @@ public class MysqlBaseSpecStore extends InstrumentedSpecStore
{
public static final String CONFIG_PREFIX = "mysqlBaseSpecStore";
public static final String DEFAULT_TAG_VALUE = "";
+ public static final String modificationTimeKey = "modified_time";
Review Comment:
Can we make this a Configuration Key or a key associated with the FlowSpec
rather than the SpecStore? Since the property is part of the flowSpec it will
encapsulate better
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]