AndyJiang99 commented on code in PR #3640:
URL: https://github.com/apache/gobblin/pull/3640#discussion_r1105121542
##########
gobblin-runtime/src/main/java/org/apache/gobblin/runtime/spec_store/MysqlBaseSpecStore.java:
##########
@@ -84,6 +84,7 @@ public class MysqlBaseSpecStore extends InstrumentedSpecStore
{
private static final String GET_ALL_STATEMENT = "SELECT spec_uri, spec FROM
%s";
private static final String GET_ALL_URIS_STATEMENT = "SELECT spec_uri FROM
%s";
private static final String GET_ALL_URIS_WITH_TAG_STATEMENT = "SELECT
spec_uri FROM %s WHERE tag = ?";
+ private static final String GET_SPECS_BATCH_STATEMENT = "SELECT spec_uri,
spec FROM %s ORDER BY spec_uri ASC LIMIT ? OFFSET ?";
Review Comment:
1. Was there any reason why spec_json was removed from the query string?
2. Using this query, it will error in the scenario the OFFSET or LIMIT was
set to a negative value as MySQL queries cannot handle those and this [if
block](https://github.com/apache/gobblin/pull/3640/files#diff-900cc8e4e863a8057e0e808230a2f9c3c169048059d62a5d94ed9beb94360c12L283-L293)
handles such cases. We'll need to add something similar in to handle those
cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
