[
https://issues.apache.org/jira/browse/GOBBLIN-1786?focusedWorklogId=846740&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-846740
]
ASF GitHub Bot logged work on GOBBLIN-1786:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 21/Feb/23 21:56
Start Date: 21/Feb/23 21:56
Worklog Time Spent: 10m
Work Description: meethngala commented on code in PR #3643:
URL: https://github.com/apache/gobblin/pull/3643#discussion_r1113609147
##########
gobblin-data-management/src/main/java/org/apache/gobblin/data/management/copy/iceberg/IcebergHiveCatalog.java:
##########
@@ -17,22 +17,54 @@
package org.apache.gobblin.data.management.copy.iceberg;
-import lombok.AllArgsConstructor;
-import lombok.extern.slf4j.Slf4j;
-
+import org.apache.iceberg.catalog.Catalog;
import org.apache.iceberg.catalog.TableIdentifier;
import org.apache.iceberg.hive.HiveCatalog;
+import lombok.extern.slf4j.Slf4j;
+
/**
* Hive-Metastore-based {@link IcebergCatalog}.
*/
@Slf4j
-@AllArgsConstructor
public class IcebergHiveCatalog implements IcebergCatalog {
+
+ /**
+ * Ensures pairing between {@link IcebergCatalog} and its implementation
type i.e. {@link HiveCatalog} in this case.
+ * Unfortunately, {@link
org.apache.iceberg.BaseMetastoreCatalog}.newTableOps is protected.
+ * Hence, it necessitates this abstraction to define and access {@link
IcebergTable}
+ */
+ public static class HiveSpecifier implements CatalogSpecifier {
+
+ public static final String HIVE_CATALOG_NAME = "hive";
+ @Override
+ public Class<? extends Catalog> getCatalogClass() {
+ return HiveCatalog.class;
+ }
+
+ @Override
+ public Class<? extends IcebergCatalog> getIcebergCatalogClass() {
+ return IcebergHiveCatalog.class;
+ }
+
+ @Override
+ public String getCatalogName() {
+ return HIVE_CATALOG_NAME;
+ }
+ }
+
// NOTE: specifically necessitates `HiveCatalog`, as
`BaseMetastoreCatalog.newTableOps` is `protected`!
private final HiveCatalog hc;
+ public IcebergHiveCatalog(Catalog catalog) {
+ if (catalog instanceof HiveCatalog) {
+ hc = (HiveCatalog) catalog;
+ } else {
+ throw new IllegalArgumentException(String.format("Incorrect Catalog
Provided: Got %s instead of HiveCatalog " ,catalog.getClass().getName()));
Review Comment:
yeah... good catch 👍
Issue Time Tracking
-------------------
Worklog Id: (was: 846740)
Time Spent: 2h 20m (was: 2h 10m)
> Support Other Catalog Types for Iceberg Distcp
> ----------------------------------------------
>
> Key: GOBBLIN-1786
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1786
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Meeth Gala
> Priority: Major
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
