[
https://issues.apache.org/jira/browse/GOBBLIN-1786?focusedWorklogId=846742&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-846742
]
ASF GitHub Bot logged work on GOBBLIN-1786:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 21/Feb/23 21:57
Start Date: 21/Feb/23 21:57
Worklog Time Spent: 10m
Work Description: meethngala commented on code in PR #3643:
URL: https://github.com/apache/gobblin/pull/3643#discussion_r1113609977
##########
gobblin-data-management/src/main/java/org/apache/gobblin/data/management/copy/iceberg/IcebergDataset.java:
##########
@@ -87,8 +87,8 @@ public IcebergDataset(String db, String table, IcebergTable
icebergTbl, Properti
this.icebergTable = icebergTbl;
this.properties = properties;
this.sourceFs = sourceFs;
- this.sourceCatalogMetastoreURI = getAsOptionalURI(this.properties,
IcebergDatasetFinder.ICEBERG_HIVE_CATALOG_METASTORE_URI_KEY);
- this.targetCatalogMetastoreURI = getAsOptionalURI(this.properties,
TARGET_METASTORE_URI_KEY);
+ this.sourceCatalogURI = getAsOptionalURI(this.properties,
IcebergDatasetFinder.ICEBERG_SRC_CATALOG_URI_KEY);
Review Comment:
I have encapsulated the catalog uri information to be a part of
`IcebergCatalog` and added the TODO for target catalog!
Issue Time Tracking
-------------------
Worklog Id: (was: 846742)
Time Spent: 2.5h (was: 2h 20m)
> Support Other Catalog Types for Iceberg Distcp
> ----------------------------------------------
>
> Key: GOBBLIN-1786
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1786
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Meeth Gala
> Priority: Major
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
