[
https://issues.apache.org/jira/browse/GOBBLIN-1786?focusedWorklogId=847069&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-847069
]
ASF GitHub Bot logged work on GOBBLIN-1786:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 22/Feb/23 22:38
Start Date: 22/Feb/23 22:38
Worklog Time Spent: 10m
Work Description: ZihanLi58 commented on code in PR #3643:
URL: https://github.com/apache/gobblin/pull/3643#discussion_r1115049962
##########
gobblin-data-management/src/main/java/org/apache/gobblin/data/management/copy/iceberg/IcebergCatalog.java:
##########
@@ -17,10 +17,25 @@
package org.apache.gobblin.data.management.copy.iceberg;
+import org.apache.iceberg.catalog.Catalog;
+
/**
* Any catalog from which to access {@link IcebergTable}s.
*/
public interface IcebergCatalog {
IcebergTable openTable(String dbName, String tableName);
+ String getCatalogUri();
+
+ /**
+ * Adding a sub interface to help us provide an association between {@link
Catalog} and {@link IcebergCatalog}.
+ * This helps us resolve to the Catalog to its concrete implementation class
+ * Primarily needed to access `newTableOps` method which only certain {@link
Catalog} derived classes open for public access
+ */
+ interface CatalogSpecifier {
Review Comment:
For other types of iceberg operation, it seems like gobblin icebergCatalog
is not needed. And it does not make sense for me to declare a specifier if I
just want to use a different type of catalog.
Can we have only one Gobblin IcebergCatalog class that takes the normal
catalog, and throw an exception if the normal catalog does not set newTableOps
as a public method? You can use this
https://www.digitalocean.com/community/tutorials/java-reflection-example-tutoria
to check whether a method is protect or public
Issue Time Tracking
-------------------
Worklog Id: (was: 847069)
Time Spent: 3h 40m (was: 3.5h)
> Support Other Catalog Types for Iceberg Distcp
> ----------------------------------------------
>
> Key: GOBBLIN-1786
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1786
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Meeth Gala
> Priority: Major
> Time Spent: 3h 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
