Will-Lo commented on code in PR #3643:
URL: https://github.com/apache/gobblin/pull/3643#discussion_r1122301399
##########
gobblin-data-management/src/main/java/org/apache/gobblin/data/management/copy/iceberg/IcebergDatasetFinder.java:
##########
@@ -21,19 +21,25 @@
import java.util.ArrayList;
import java.util.Iterator;
import java.util.List;
+import java.util.Map;
+import java.util.Optional;
import java.util.Properties;
import org.apache.commons.lang.StringUtils;
import org.apache.hadoop.conf.Configuration;
import org.apache.hadoop.fs.FileSystem;
import org.apache.hadoop.fs.Path;
+import com.google.api.client.util.Maps;
Review Comment:
Still see this dep? You can remove it if it's a dead import
##########
gobblin-data-management/src/main/java/org/apache/gobblin/data/management/copy/iceberg/IcebergCatalogFactory.java:
##########
@@ -17,20 +17,24 @@
package org.apache.gobblin.data.management.copy.iceberg;
+import java.io.IOException;
+import java.util.Map;
import org.apache.hadoop.conf.Configuration;
-import org.apache.iceberg.hive.HiveCatalog;
-
-import com.google.common.collect.Maps;
+import org.apache.gobblin.util.reflection.GobblinConstructorUtils;
/**
* Provides an {@link IcebergCatalog}.
*/
public class IcebergCatalogFactory {
- public static IcebergCatalog create(Configuration configuration) {
- HiveCatalog hcat = new HiveCatalog();
- hcat.setConf(configuration);
- hcat.initialize("hive", Maps.newHashMap());
- return new IcebergHiveCatalog(hcat);
+ public static IcebergCatalog create(String icebergCatalogType, Map<String,
String> properties, Configuration configuration) throws IOException {
Review Comment:
Can you rename `icebergCatalogType` to `icebergCatalogClassName`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
