meethngala commented on code in PR #3643:
URL: https://github.com/apache/gobblin/pull/3643#discussion_r1122461100
##########
gobblin-data-management/src/main/java/org/apache/gobblin/data/management/copy/iceberg/IcebergDataset.java:
##########
@@ -319,11 +320,11 @@ protected static Optional<URI>
getAsOptionalURI(Properties props, String key) {
}
protected DatasetDescriptor getSourceDataset(FileSystem sourceFs) {
- return getDatasetDescriptor(sourceCatalogMetastoreURI, sourceFs);
+ return getDatasetDescriptor(sourceCatalogURI, sourceFs);
Review Comment:
I see, it would be a dataset level descriptor since the `fileSetId` captures
the dbName and tableName. However, I agree that perhaps we should have this
method inside `IcebergTable` and call the dataset descriptor for src and dest
accordingly. I have made the changes and pushed it in my latest commit!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
