phet commented on code in PR #3643:
URL: https://github.com/apache/gobblin/pull/3643#discussion_r1122366528
##########
gobblin-data-management/src/main/java/org/apache/gobblin/data/management/copy/iceberg/IcebergDataset.java:
##########
@@ -319,11 +320,11 @@ protected static Optional<URI>
getAsOptionalURI(Properties props, String key) {
}
protected DatasetDescriptor getSourceDataset(FileSystem sourceFs) {
- return getDatasetDescriptor(sourceCatalogMetastoreURI, sourceFs);
+ return getDatasetDescriptor(sourceCatalogURI, sourceFs);
Review Comment:
is this a dataset-level descriptor? seems it would be the same for all
datasets from the same catalog, rather than distinct for each... is that really
sufficient?
perhaps `IcebergTable` deserves a (table-specific)
`getDatasetDescriptor(FileSystem)` method?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
