[
https://issues.apache.org/jira/browse/GOBBLIN-1802?focusedWorklogId=853787&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-853787
]
ASF GitHub Bot logged work on GOBBLIN-1802:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 29/Mar/23 20:12
Start Date: 29/Mar/23 20:12
Worklog Time Spent: 10m
Work Description: meethngala commented on code in PR #3663:
URL: https://github.com/apache/gobblin/pull/3663#discussion_r1152433195
##########
gobblin-data-management/src/main/java/org/apache/gobblin/data/management/copy/iceberg/IcebergTable.java:
##########
@@ -194,4 +194,9 @@ protected DatasetDescriptor getDatasetDescriptor(FileSystem
fs) {
descriptor.addMetadata(DatasetConstants.FS_URI, fs.getUri().toString());
return descriptor;
}
+ /** Registers {@link IcebergTable} after publishing data.
+ * @param dstMetadata is null if target {@link IcebergTable} is absent */
Review Comment:
I have updated the Javadoc and check to skip committing if dest metadata is
not present
Issue Time Tracking
-------------------
Worklog Id: (was: 853787)
Time Spent: 3h 20m (was: 3h 10m)
> Register iceberg table metadata update with destination side catalog
> --------------------------------------------------------------------
>
> Key: GOBBLIN-1802
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1802
> Project: Apache Gobblin
> Issue Type: New Feature
> Reporter: Meeth Gala
> Priority: Major
> Time Spent: 3h 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
