[
https://issues.apache.org/jira/browse/GOBBLIN-1802?focusedWorklogId=854270&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-854270
]
ASF GitHub Bot logged work on GOBBLIN-1802:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 31/Mar/23 21:04
Start Date: 31/Mar/23 21:04
Worklog Time Spent: 10m
Work Description: Will-Lo commented on code in PR #3663:
URL: https://github.com/apache/gobblin/pull/3663#discussion_r1154893472
##########
gobblin-data-management/src/main/java/org/apache/gobblin/data/management/copy/iceberg/IcebergDatasetFinder.java:
##########
@@ -125,14 +126,14 @@ protected IcebergCatalog createIcebergCatalog(Properties
properties, CatalogLoca
switch (location) {
case SOURCE:
catalogUri = properties.getProperty(ICEBERG_SRC_CATALOG_URI_KEY);
- Preconditions.checkNotNull(catalogUri, "Source Catalog Table Service
URI is required");
+ Preconditions.checkNotNull(catalogUri, "Provided: {%s} Source Catalog
Table Service URI is required", catalogUri);
Review Comment:
Correct me if I'm wrong here, but wouldn't this message always equate to:
```
Provided: null Source Catalog Table Service URI is required
```
I think I just wanted you to provide the ICEBERG_SRC_CATALOG_URI_KEY
Issue Time Tracking
-------------------
Worklog Id: (was: 854270)
Time Spent: 4h 10m (was: 4h)
> Register iceberg table metadata update with destination side catalog
> --------------------------------------------------------------------
>
> Key: GOBBLIN-1802
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1802
> Project: Apache Gobblin
> Issue Type: New Feature
> Reporter: Meeth Gala
> Priority: Major
> Time Spent: 4h 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
