[
https://issues.apache.org/jira/browse/GOBBLIN-1802?focusedWorklogId=854229&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-854229
]
ASF GitHub Bot logged work on GOBBLIN-1802:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 31/Mar/23 17:43
Start Date: 31/Mar/23 17:43
Worklog Time Spent: 10m
Work Description: meethngala commented on code in PR #3663:
URL: https://github.com/apache/gobblin/pull/3663#discussion_r1154739467
##########
gradle/scripts/dependencyDefinitions.gradle:
##########
@@ -123,7 +123,7 @@ ext.externalDependency = [
"guiceMultibindings":
"com.google.inject.extensions:guice-multibindings:4.0",
"guiceServlet": "com.google.inject.extensions:guice-servlet:4.0",
"derby": "org.apache.derby:derby:10.12.1.1",
- "mockito": "org.mockito:mockito-core:4.11.0",
+ "mockito": "org.mockito:mockito-inline:4.11.0",
Review Comment:
yeah sure, I'll add a comment for using inline vs core. The rationale was to
allow testing of mocked ctors, static and final methods that we are using for
iceberg distcp. Moreover, inline mockito transitively brings in the
mockito-core as well!
Issue Time Tracking
-------------------
Worklog Id: (was: 854229)
Time Spent: 3h 50m (was: 3h 40m)
> Register iceberg table metadata update with destination side catalog
> --------------------------------------------------------------------
>
> Key: GOBBLIN-1802
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1802
> Project: Apache Gobblin
> Issue Type: New Feature
> Reporter: Meeth Gala
> Priority: Major
> Time Spent: 3h 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
