[
https://issues.apache.org/jira/browse/GOBBLIN-1805?focusedWorklogId=854909&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-854909
]
ASF GitHub Bot logged work on GOBBLIN-1805:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 05/Apr/23 01:03
Start Date: 05/Apr/23 01:03
Worklog Time Spent: 10m
Work Description: codecov-commenter commented on PR #3666:
URL: https://github.com/apache/gobblin/pull/3666#issuecomment-1496785526
##
[Codecov](https://codecov.io/gh/apache/gobblin/pull/3666?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
Report
> Merging
[#3666](https://codecov.io/gh/apache/gobblin/pull/3666?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(e24261a) into
[master](https://codecov.io/gh/apache/gobblin/commit/7675dc43dd7128bb2daedb8c6b826e8fcc9104c7?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(7675dc4) will **increase** coverage by `4.16%`.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## master #3666 +/- ##
============================================
+ Coverage 46.97% 51.14% +4.16%
+ Complexity 10780 7210 -3570
============================================
Files 2138 1345 -793
Lines 83992 50652 -33340
Branches 9332 5630 -3702
============================================
- Hits 39455 25904 -13551
+ Misses 40959 22487 -18472
+ Partials 3578 2261 -1317
```
| [Impacted
Files](https://codecov.io/gh/apache/gobblin/pull/3666?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
| Coverage Δ | |
|---|---|---|
|
[...obblin/service/FlowConfigResourceLocalHandler.java](https://codecov.io/gh/apache/gobblin/pull/3666?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1yZXN0bGkvZ29iYmxpbi1mbG93LWNvbmZpZy1zZXJ2aWNlL2dvYmJsaW4tZmxvdy1jb25maWctc2VydmljZS1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vc2VydmljZS9GbG93Q29uZmlnUmVzb3VyY2VMb2NhbEhhbmRsZXIuamF2YQ==)
| `12.40% <0.00%> (-3.29%)` | :arrow_down: |
|
[...blin/service/FlowConfigV2ResourceLocalHandler.java](https://codecov.io/gh/apache/gobblin/pull/3666?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1yZXN0bGkvZ29iYmxpbi1mbG93LWNvbmZpZy1zZXJ2aWNlL2dvYmJsaW4tZmxvdy1jb25maWctc2VydmljZS1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vc2VydmljZS9GbG93Q29uZmlnVjJSZXNvdXJjZUxvY2FsSGFuZGxlci5qYXZh)
| `0.00% <ø> (ø)` | |
... and [795 files with indirect coverage
changes](https://codecov.io/gh/apache/gobblin/pull/3666/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD
build times. [Learn
more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
Issue Time Tracking
-------------------
Worklog Id: (was: 854909)
Time Spent: 20m (was: 10m)
> Check watermark for the most recent hour for quiet topics
> ---------------------------------------------------------
>
> Key: GOBBLIN-1805
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1805
> Project: Apache Gobblin
> Issue Type: Task
> Reporter: Vikram Bohra
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Currently, Audit check is done for [currentWatermark, currentWatermark
> +1hour] window for quiet topics. However when the audit check for this window
> fails (due to an upstream bug in audit), the watermark never progress as the
> currentWatermark is never updated. To avoid this we keep progressing the
> watermark by checking the window [currentHour -1, currentHour] window
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
