[
https://issues.apache.org/jira/browse/GOBBLIN-1805?focusedWorklogId=862366&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-862366
]
ASF GitHub Bot logged work on GOBBLIN-1805:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 25/May/23 21:16
Start Date: 25/May/23 21:16
Worklog Time Spent: 10m
Work Description: vikrambohra opened a new pull request, #3698:
URL: https://github.com/apache/gobblin/pull/3698
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I
have checked off all the steps below!
### JIRA
- [ ] My PR addresses the following [Gobblin
JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references
them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-1805
### Description
- [ ] Here are some details about my PR, including screenshots (if
applicable):
Currently, Audit check is done for [currentWatermark, currentWatermark
+1hour] window for quiet topics. However when the audit check for this window
fails (due to an upstream bug in audit), the watermark never progress as the
currentWatermark is never updated. To avoid this we keep progressing the
watermark by checking the window [currentHour -1, currentHour] window
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
Updated unit test to reflect this change
### Commits
- [ ] My commits all reference JIRA issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
Issue Time Tracking
-------------------
Worklog Id: (was: 862366)
Time Spent: 0.5h (was: 20m)
> Check watermark for the most recent hour for quiet topics
> ---------------------------------------------------------
>
> Key: GOBBLIN-1805
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1805
> Project: Apache Gobblin
> Issue Type: Task
> Reporter: Vikram Bohra
> Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Currently, Audit check is done for [currentWatermark, currentWatermark
> +1hour] window for quiet topics. However when the audit check for this window
> fails (due to an upstream bug in audit), the watermark never progress as the
> currentWatermark is never updated. To avoid this we keep progressing the
> watermark by checking the window [currentHour -1, currentHour] window
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
