[
https://issues.apache.org/jira/browse/GOBBLIN-1805?focusedWorklogId=862392&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-862392
]
ASF GitHub Bot logged work on GOBBLIN-1805:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 26/May/23 00:33
Start Date: 26/May/23 00:33
Worklog Time Spent: 10m
Work Description: codecov-commenter commented on PR #3698:
URL: https://github.com/apache/gobblin/pull/3698#issuecomment-1563664347
##
[Codecov](https://app.codecov.io/gh/apache/gobblin/pull/3698?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
Report
> Merging
[#3698](https://app.codecov.io/gh/apache/gobblin/pull/3698?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
(a7d398d) into
[master](https://app.codecov.io/gh/apache/gobblin/commit/158d6fff546ee28ad7b542bfe78e5263af8843c6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
(158d6ff) will **decrease** coverage by `4.68%`.
> The diff coverage is `100.00%`.
```diff
@@ Coverage Diff @@
## master #3698 +/- ##
============================================
- Coverage 49.45% 44.78% -4.68%
+ Complexity 9309 2095 -7214
============================================
Files 1756 411 -1345
Lines 68468 17726 -50742
Branches 7809 2161 -5648
============================================
- Hits 33862 7938 -25924
+ Misses 31466 8927 -22539
+ Partials 3140 861 -2279
```
| [Impacted
Files](https://app.codecov.io/gh/apache/gobblin/pull/3698?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
| Coverage Δ | |
|---|---|---|
|
[.../gobblin/iceberg/writer/IcebergMetadataWriter.java](https://app.codecov.io/gh/apache/gobblin/pull/3698?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z29iYmxpbi1pY2ViZXJnL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2ljZWJlcmcvd3JpdGVyL0ljZWJlcmdNZXRhZGF0YVdyaXRlci5qYXZh)
| `72.31% <100.00%> (-0.05%)` | :arrow_down: |
... and [1349 files with indirect coverage
changes](https://app.codecov.io/gh/apache/gobblin/pull/3698/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD
build times. [Learn
more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
Issue Time Tracking
-------------------
Worklog Id: (was: 862392)
Time Spent: 50m (was: 40m)
> Check watermark for the most recent hour for quiet topics
> ---------------------------------------------------------
>
> Key: GOBBLIN-1805
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1805
> Project: Apache Gobblin
> Issue Type: Task
> Reporter: Vikram Bohra
> Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Currently, Audit check is done for [currentWatermark, currentWatermark
> +1hour] window for quiet topics. However when the audit check for this window
> fails (due to an upstream bug in audit), the watermark never progress as the
> currentWatermark is never updated. To avoid this we keep progressing the
> watermark by checking the window [currentHour -1, currentHour] window
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
