[
https://issues.apache.org/jira/browse/GOBBLIN-1835?focusedWorklogId=862046&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-862046
]
ASF GitHub Bot logged work on GOBBLIN-1835:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 22/May/23 21:04
Start Date: 22/May/23 21:04
Worklog Time Spent: 10m
Work Description: ZihanLi58 commented on code in PR #3697:
URL: https://github.com/apache/gobblin/pull/3697#discussion_r1201100605
##########
gobblin-iceberg/src/main/java/org/apache/gobblin/iceberg/Utils/IcebergUtils.java:
##########
@@ -248,6 +248,7 @@ public static DataFile
getIcebergDataFileWithMetric(org.apache.gobblin.metadata.
IcebergUtils.getMapFromIntegerLongPairs(file.getFileMetrics().getColumnSizes(),
schemaIdMap),
IcebergUtils.getMapFromIntegerLongPairs(file.getFileMetrics().getValueCounts(),
schemaIdMap),
IcebergUtils.getMapFromIntegerLongPairs(file.getFileMetrics().getNullValueCounts(),
schemaIdMap),
+ IcebergUtils.getMapFromIntegerLongPairs(Lists.newArrayList(),
schemaIdMap), // metric value will be null since Nan values are supported from
avro version 1.10.*
Review Comment:
Do we know which metric is added? I don't believe we should give Nan here.
It's true in avro version, it's null but how about ORC files?
https://github.com/apache/gobblin/pull/3697/files#diff-8ed59fcb5438eea6df2d8ed2256d2eac003a523c7af29aeef7fd6a7a151fbbabR214
we do get all metrics for ORC files, so we should publish it here as well.
Issue Time Tracking
-------------------
Worklog Id: (was: 862046)
Time Spent: 20m (was: 10m)
> Upgrade Iceberg Version from 0.11.1 to 1.2.0
> --------------------------------------------
>
> Key: GOBBLIN-1835
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1835
> Project: Apache Gobblin
> Issue Type: New Feature
> Reporter: Meeth Gala
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
