[
https://issues.apache.org/jira/browse/GOBBLIN-1835?focusedWorklogId=865366&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-865366
]
ASF GitHub Bot logged work on GOBBLIN-1835:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 13/Jun/23 21:33
Start Date: 13/Jun/23 21:33
Worklog Time Spent: 10m
Work Description: meethngala commented on code in PR #3697:
URL: https://github.com/apache/gobblin/pull/3697#discussion_r1228717988
##########
gobblin-iceberg/src/test/java/org/apache/gobblin/iceberg/writer/HiveMetadataWriterTest.java:
##########
@@ -128,7 +128,6 @@ public void clean() throws Exception {
@BeforeSuite
public void setUp() throws Exception {
Class.forName("org.apache.derby.jdbc.EmbeddedDriver").newInstance();
- startMetastore();
Review Comment:
the local Metastore is now started by the parent class: `HiveMetastoreTest`
with the upgrade, since they now added `@BeforeClass` annotation for
`startMetastore()`. Here's the [Junit api
doc](https://junit.org/junit4/javadoc/latest/org/junit/BeforeClass.html) for
the same. Thus, we do not need to start again for our unit tests otherwise we
would run into this issue:`AlreadyExistsException(message:Database hivedb
already exists)`. Alternative would be to try starting again on our side and
catch the above exception and handle it.
Issue Time Tracking
-------------------
Worklog Id: (was: 865366)
Time Spent: 1h 40m (was: 1.5h)
> Upgrade Iceberg Version from 0.11.1 to 1.2.0
> --------------------------------------------
>
> Key: GOBBLIN-1835
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1835
> Project: Apache Gobblin
> Issue Type: New Feature
> Reporter: Meeth Gala
> Priority: Major
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
