[
https://issues.apache.org/jira/browse/GOBBLIN-1835?focusedWorklogId=865353&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-865353
]
ASF GitHub Bot logged work on GOBBLIN-1835:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 13/Jun/23 20:02
Start Date: 13/Jun/23 20:02
Worklog Time Spent: 10m
Work Description: jack-moseley commented on code in PR #3697:
URL: https://github.com/apache/gobblin/pull/3697#discussion_r1228637715
##########
gobblin-iceberg/src/test/java/org/apache/gobblin/iceberg/writer/IcebergMetadataWriterTest.java:
##########
@@ -365,12 +364,6 @@ public void testFaultTolerant() throws Exception {
new LongWatermark(52L))));
Assert.assertEquals(gobblinMCEWriter.getDatasetErrorMap().size(), 1);
Assert.assertEquals(gobblinMCEWriter.getDatasetErrorMap().values().iterator().next().size(),
1);
- Assert.assertEquals(gobblinMCEWriter.getDatasetErrorMap()
- .get(new File(tmpDir, "testDB/testTopic").getAbsolutePath())
- .get("hivedb.testTopic").get(0).lowWatermark, 50L);
- Assert.assertEquals(gobblinMCEWriter.getDatasetErrorMap()
- .get(new File(tmpDir, "testDB/testTopic").getAbsolutePath())
- .get("hivedb.testTopic").get(0).highWatermark, 52L);
Review Comment:
Yes it seems fine to me.
Issue Time Tracking
-------------------
Worklog Id: (was: 865353)
Time Spent: 1h 20m (was: 1h 10m)
> Upgrade Iceberg Version from 0.11.1 to 1.2.0
> --------------------------------------------
>
> Key: GOBBLIN-1835
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1835
> Project: Apache Gobblin
> Issue Type: New Feature
> Reporter: Meeth Gala
> Priority: Major
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
