phet commented on code in PR #3700:
URL: https://github.com/apache/gobblin/pull/3700#discussion_r1212509675
##########
gobblin-runtime/src/main/java/org/apache/gobblin/runtime/api/DagActionStore.java:
##########
@@ -45,6 +44,11 @@ public DagAction(String flowGroup, String flowName, String
flowExecutionId, DagA
this.flowExecutionId = flowExecutionId;
this.dagActionValue = dagActionValue;
}
Review Comment:
won't `@Data` synthesize a ctor for us? also, how does the synthesized
`toString()` compare to the hand-coded one below?
##########
gobblin-metrics-libs/gobblin-metrics-base/src/main/avro/DagActionStoreChangeEvent.avsc:
##########
@@ -25,7 +25,13 @@
"compliance" : "NONE"
}, {
"name" : "dagAction",
- "type" : "string",
+ "type": "enum",
+ "name": "dagActionValue",
+ "symbols": [
+ "KILL",
+ "RESUME",
+ "LAUNCH"
+ ],
Review Comment:
usually each enum gets documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
