umustafi commented on code in PR #3700: URL: https://github.com/apache/gobblin/pull/3700#discussion_r1213679270
########## gobblin-runtime/src/main/java/org/apache/gobblin/runtime/api/SchedulerLeaseDeterminationStore.java: ########## @@ -0,0 +1,73 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.gobblin.runtime.api; + +import java.io.IOException; +import java.sql.Timestamp; + +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + + +/** + * Interface defines the two basic actions required for lease determination for each FlowActionType event for a flow. + * It is used by the {@link SchedulerLeaseAlgoHandler} to allow multiple scheduler's on different hosts to determine + * which scheduler is tasked with ensuring the FlowAction is taken for the trigger. + */ +public interface SchedulerLeaseDeterminationStore { + static final Logger LOG = LoggerFactory.getLogger(SchedulerLeaseDeterminationStore.class); + + // Enum is used to reason about the three possible scenarios that can result from an attempt to obtain a lease for a + // particular trigger event of a flow + enum LeaseAttemptStatus { + LEASE_OBTAINED, + PREVIOUS_LEASE_EXPIRED, + PREVIOUS_LEASE_VALID + } + + // Action to take on a particular flow + enum FlowActionType { + LAUNCH, + RETRY, + CANCEL, + NEXT_HOP Review Comment: In terms of action RETRY and RESUME work similarly, but we use them to describe different starting points. RETRY is invoked by [DagManager](https://jarvis.corp.linkedin.com/codesearch/result/?name=DagManager.java&path=gobblin-elr%2Fgobblin-service%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fgobblin%2Fservice%2Fmodules%2Forchestration&reponame=linkedin%2Fgobblin-elr#808) automatically if a flow fails and is configured to allow retries. RESUME is manually invoked by the user. It may be worth to have the differentiation noted for logging purposes but treat these cases the same when it comes to acting on them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
