phet commented on code in PR #3700:
URL: https://github.com/apache/gobblin/pull/3700#discussion_r1207475031
##########
gobblin-runtime/src/main/java/org/apache/gobblin/runtime/dag_action_store/MysqlDagActionStore.java:
##########
@@ -151,20 +153,21 @@ private DagAction getDagActionWithRetry(String flowGroup,
String flowName, Strin
getStatement.setString(++i, flowGroup);
getStatement.setString(++i, flowName);
getStatement.setString(++i, flowExecutionId);
+ getStatement.setString(++i, dagActionValue.toString());
Review Comment:
tip: if you want to use `DagAction` as a value type/POJO, you could even add
a method (on `DagAction`) to encapsulate this repetitive setup:
```
void prepareStatement(PreparedStatement ps, int nextVarIndex)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
