[
https://issues.apache.org/jira/browse/GOBBLIN-1844?focusedWorklogId=866834&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-866834
]
ASF GitHub Bot logged work on GOBBLIN-1844:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 21/Jun/23 19:40
Start Date: 21/Jun/23 19:40
Worklog Time Spent: 10m
Work Description: homatthew opened a new pull request, #3709:
URL: https://github.com/apache/gobblin/pull/3709
…container count
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I
have checked off all the steps below!
### JIRA
- [X] My PR addresses the following [Gobblin
JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references
them in the PR title. For example, "[GOBBLIN-1844] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-1844
### Description
- [X] Here are some details about my PR, including screenshots (if
applicable):
When the `GobblinClusterManager` starts, it will do an asynchronous deletion
of workflows (all workflow deletions are technically async). And we do not want
the yarn service to acknowledge these workflows while the controller processes
the request asynchronously.
When there is heavy load on the zookeeper cluster, the deletes will be slow
and there will be significant overlap of having 2 of the same workflows
### Tests
- [X] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
Modified existing unit to cover edge case of workflows that marked for
deletion. Also refactored the testing code to improve the readability since
there is a ton of copy paste involved for creating a workflow which is
difficult to read
### Commits
- [X] My commits all reference JIRA issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
Issue Time Tracking
-------------------
Worklog Id: (was: 866834)
Remaining Estimate: 0h
Time Spent: 10m
> YarnService should ignore workflows already marked as delete
> ------------------------------------------------------------
>
> Key: GOBBLIN-1844
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1844
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Matthew Ho
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
