[
https://issues.apache.org/jira/browse/GOBBLIN-1844?focusedWorklogId=867018&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-867018
]
ASF GitHub Bot logged work on GOBBLIN-1844:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 22/Jun/23 20:31
Start Date: 22/Jun/23 20:31
Worklog Time Spent: 10m
Work Description: ZihanLi58 commented on code in PR #3709:
URL: https://github.com/apache/gobblin/pull/3709#discussion_r1239001875
##########
gobblin-yarn/src/main/java/org/apache/gobblin/yarn/YarnAutoScalingManager.java:
##########
@@ -220,16 +220,18 @@ void runInternal() {
YarnContainerRequestBundle yarnContainerRequestBundle = new
YarnContainerRequestBundle();
for (Map.Entry<String, WorkflowConfig> workFlowEntry :
taskDriver.getWorkflows().entrySet()) {
WorkflowContext workflowContext =
taskDriver.getWorkflowContext(workFlowEntry.getKey());
+ WorkflowConfig workflowConfig = workFlowEntry.getValue();
- // Only allocate for active workflows
- if (workflowContext == null ||
!workflowContext.getWorkflowState().equals(TaskState.IN_PROGRESS)) {
+ // Only allocate for active workflows and those not marked for delete
Review Comment:
Can you add a comment here to explain that we won't release the container
immediately as we allow containers to be idle for a specific time?
Issue Time Tracking
-------------------
Worklog Id: (was: 867018)
Time Spent: 0.5h (was: 20m)
> YarnService should ignore workflows already marked as delete
> ------------------------------------------------------------
>
> Key: GOBBLIN-1844
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1844
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Matthew Ho
> Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
