[
https://issues.apache.org/jira/browse/GOBBLIN-1844?focusedWorklogId=866837&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-866837
]
ASF GitHub Bot logged work on GOBBLIN-1844:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 21/Jun/23 19:43
Start Date: 21/Jun/23 19:43
Worklog Time Spent: 10m
Work Description: homatthew commented on code in PR #3709:
URL: https://github.com/apache/gobblin/pull/3709#discussion_r1237601115
##########
gobblin-yarn/src/test/java/org/apache/gobblin/yarn/YarnAutoScalingManagerTest.java:
##########
@@ -223,117 +150,64 @@ public void testTwoWorkflows() throws IOException {
runnable.run();
// 5 containers requested and 3 workers in use
- ArgumentCaptor<YarnContainerRequestBundle> argument =
ArgumentCaptor.forClass(YarnContainerRequestBundle.class);
- Mockito.verify(mockYarnService, times(1)).
- requestTargetNumberOfContainers(argument.capture(),
- eq(ImmutableSet.of("GobblinYarnTaskRunner-1",
"GobblinYarnTaskRunner-2", "GobblinYarnTaskRunner-3")));
- Assert.assertEquals(argument.getValue().getTotalContainers(), 5);
+ assertContainerRequest(mockYarnService, 5,
+ ImmutableSet.of("GobblinYarnTaskRunner-1", "GobblinYarnTaskRunner-2",
"GobblinYarnTaskRunner-3"));
}
/**
- * Test for two workflows with one not in progress.
- * The partitions for the workflow that is not in progress should not be
counted.
+ * Test for three workflows with one not in progress and one marked for
delete.
+ * The partitions for the workflow that is not in progress or is marked for
delete should not be counted.
*/
@Test
- public void testNotInProgress() throws IOException {
+ public void testNotInProgressOrBeingDeleted() {
Review Comment:
This is the test that covers the related `impl` changes. The changes in the
other test methods are all refactors
Issue Time Tracking
-------------------
Worklog Id: (was: 866837)
Time Spent: 20m (was: 10m)
> YarnService should ignore workflows already marked as delete
> ------------------------------------------------------------
>
> Key: GOBBLIN-1844
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1844
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Matthew Ho
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
