[
https://issues.apache.org/jira/browse/GOBBLIN-1875?focusedWorklogId=876227&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-876227
]
ASF GitHub Bot logged work on GOBBLIN-1875:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 14/Aug/23 23:00
Start Date: 14/Aug/23 23:00
Worklog Time Spent: 10m
Work Description: umustafi opened a new pull request, #3737:
URL: https://github.com/apache/gobblin/pull/3737
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I
have checked off all the steps below!
### JIRA
- [X] My PR addresses the following [Gobblin
JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references
them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-1875
### Description
- [X] Here are some details about my PR, including screenshots (if
applicable):
We are seeing the following errors when trying to schedule reminders for
Multi-active scheduler after losing lease acquisition:
`Unable to store Trigger with name: '...' and group: '...' because one
already exists with this identification`
The Quartz scheduler allows multiple unique triggers mapping to one job in a
N:1 relation, but this requires the trigger having a unique identifier
associated with it. When we create triggers, we were previously using only the
job name and group to identify the trigger so we're unable to add additional
triggers for the same job. The trigger key is only used internally by the
Quartz scheduler, so it is safe to manipulate by adding a random number to
identify the trigger. We also don't expect more than a handful of triggers
associated with a job, so an int 0 to 1000 will be sufficient to uniquely
identify the trigger.
### Tests
- [X] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
`testCreateUniqueTriggersForJob` creates two triggers with the same job key
and verifies the trigger key's are unique
### Commits
- [X] My commits all reference JIRA issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
Issue Time Tracking
-------------------
Worklog Id: (was: 876227)
Remaining Estimate: 0h
Time Spent: 10m
> Create Unique Trigger identifiers
> ----------------------------------
>
> Key: GOBBLIN-1875
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1875
> Project: Apache Gobblin
> Issue Type: Bug
> Components: gobblin-service
> Reporter: Urmi Mustafi
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> We are seeing the following errors when trying to schedule reminders for
> Multi-active scheduler after losing lease acquisition:
> {{Unable to store Trigger with name: '...' and group: '...' because one
> already exists with this identification}}
> The Quartz scheduler allows multiple unique triggers mapping to one job in a
> N:1 relation, but this requires the trigger having a unique identifier
> associated with it. When we create triggers, we were previously using only
> the job name and group to identify the trigger so we're unable to add
> additional triggers for the same job. The trigger key is only used internally
> by the Quartz scheduler, so it is safe to manipulate by adding a random
> number to identify the trigger. We also don't expect more than a handful of
> triggers associated with a job, so an int 0 to 1000 will be sufficient to
> uniquely identify the trigger.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
