[
https://issues.apache.org/jira/browse/GOBBLIN-1875?focusedWorklogId=876237&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-876237
]
ASF GitHub Bot logged work on GOBBLIN-1875:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 15/Aug/23 00:39
Start Date: 15/Aug/23 00:39
Worklog Time Spent: 10m
Work Description: codecov-commenter commented on PR #3737:
URL: https://github.com/apache/gobblin/pull/3737#issuecomment-1678271325
##
[Codecov](https://app.codecov.io/gh/apache/gobblin/pull/3737?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
Report
> Merging
[#3737](https://app.codecov.io/gh/apache/gobblin/pull/3737?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
(bf014c8) into
[master](https://app.codecov.io/gh/apache/gobblin/commit/7dbf7b6a5fc9298332335eca6a9aaf76b39cf715?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
(7dbf7b6) will **increase** coverage by `1.36%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head bf014c8 differs from pull request most recent
head cb63e59. Consider uploading reports for the commit cb63e59 to get more
accurate results
```diff
@@ Coverage Diff @@
## master #3737 +/- ##
============================================
+ Coverage 47.08% 48.44% +1.36%
+ Complexity 10864 3525 -7339
============================================
Files 2147 694 -1453
Lines 84825 28164 -56661
Branches 9412 3282 -6130
============================================
- Hits 39936 13644 -26292
+ Misses 41264 13130 -28134
+ Partials 3625 1390 -2235
```
| [Files
Changed](https://app.codecov.io/gh/apache/gobblin/pull/3737?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
| Coverage Δ | |
|---|---|---|
|
[...vice/modules/orchestration/FlowTriggerHandler.java](https://app.codecov.io/gh/apache/gobblin/pull/3737?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z29iYmxpbi1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9kdWxlcy9vcmNoZXN0cmF0aW9uL0Zsb3dUcmlnZ2VySGFuZGxlci5qYXZh)
| `2.70% <0.00%> (-0.12%)` | :arrow_down: |
... and [1454 files with indirect coverage
changes](https://app.codecov.io/gh/apache/gobblin/pull/3737/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD
build times. [Learn
more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
Issue Time Tracking
-------------------
Worklog Id: (was: 876237)
Time Spent: 1h 10m (was: 1h)
> Create Unique Trigger identifiers
> ----------------------------------
>
> Key: GOBBLIN-1875
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1875
> Project: Apache Gobblin
> Issue Type: Bug
> Components: gobblin-service
> Reporter: Urmi Mustafi
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> We are seeing the following errors when trying to schedule reminders for
> Multi-active scheduler after losing lease acquisition:
> {{Unable to store Trigger with name: '...' and group: '...' because one
> already exists with this identification}}
> The Quartz scheduler allows multiple unique triggers mapping to one job in a
> N:1 relation, but this requires the trigger having a unique identifier
> associated with it. When we create triggers, we were previously using only
> the job name and group to identify the trigger so we're unable to add
> additional triggers for the same job. The trigger key is only used internally
> by the Quartz scheduler, so it is safe to manipulate by adding a random
> number to identify the trigger. We also don't expect more than a handful of
> triggers associated with a job, so an int 0 to 1000 will be sufficient to
> uniquely identify the trigger.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
