ZihanLi58 commented on code in PR #3738:
URL: https://github.com/apache/gobblin/pull/3738#discussion_r1294099468
##########
gobblin-modules/gobblin-kafka-common/src/main/java/org/apache/gobblin/source/extractor/extract/kafka/KafkaExtractor.java:
##########
@@ -337,4 +340,24 @@ public void close() throws IOException {
public long getHighWatermark() {
return 0;
}
+
+ public static String getKafkaBrokerSimpleName(State state) {
Review Comment:
Can we consider putting this method directly under the common utils? Also
return list of broker name if there are more than one broker specified? We can
rely on downstream method to determine whether there should be 1 broker or more
broker in the brokers config?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
