ZihanLi58 commented on code in PR #3738:
URL: https://github.com/apache/gobblin/pull/3738#discussion_r1295044694
##########
gobblin-api/src/main/java/org/apache/gobblin/configuration/ConfigurationKeys.java:
##########
@@ -916,7 +916,7 @@ public class ConfigurationKeys {
* Kafka job configurations.
*/
public static final String KAFKA_BROKERS = "kafka.brokers";
- public static final String KAFKA_BROKER_TO_SIMPLE_NAME_MAP_KEY =
ConfigurationKeys.KAFKA_BROKERS + ".simpleNameMap";
+ public static final String KAFKA_BROKER_TO_SIMPLE_NAME_MAP_KEY =
ConfigurationKeys.KAFKA_BROKERS + "ToSimpleNameMap";
Review Comment:
this definition is a little wired. Can you just change it to be
"kafka.brokersToSimpleNameMap"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
