[
https://issues.apache.org/jira/browse/GOBBLIN-1934?focusedWorklogId=886873&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-886873
]
ASF GitHub Bot logged work on GOBBLIN-1934:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 24/Oct/23 06:01
Start Date: 24/Oct/23 06:01
Worklog Time Spent: 10m
Work Description: phet commented on code in PR #3805:
URL: https://github.com/apache/gobblin/pull/3805#discussion_r1369648784
##########
gobblin-runtime/src/main/java/org/apache/gobblin/runtime/kafka/HighLevelConsumer.java:
##########
@@ -237,13 +257,16 @@ protected void startUp() {
private void consume() {
try {
Iterator<KafkaConsumerRecord> itr = gobblinKafkaConsumerClient.consume();
+ // TODO: we may be committing too early and only want to commit after
process messages
if(!enableAutoCommit) {
commitOffsets();
}
while (itr.hasNext()) {
KafkaConsumerRecord record = itr.next();
int idx = record.getPartition() % numThreads;
queues[idx].put(record);
+ // Increment queue size metric
+ updateQueueSizes(idx);
Review Comment:
this is a pretty fundamental change to put into the fast path! we gotta be
certain that no critical use is adversely affected by perf regression.
I see `ConcurrentLinkedQueue::size` javadoc saying `O(n)`, but I can't find
a statement on `LinkedBlockingQueue::size`...
(it's possible it IS `O(1)`, but an approximation... or it may be exact, but
at the expense of coordination overhead.)
Issue Time Tracking
-------------------
Worklog Id: (was: 886873)
Time Spent: 40m (was: 0.5h)
> Monitor High Level Consumer queue size
> --------------------------------------
>
> Key: GOBBLIN-1934
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1934
> Project: Apache Gobblin
> Issue Type: Improvement
> Components: gobblin-service
> Reporter: Urmi Mustafi
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
> We suspect that the HighLevelConsumer class may be dropping Kafka messages if
> the thread for a particular consumption queue is interrupted or stalled.
> Before changing how these queues are handled, we want to verify that blocked
> or dropped queues is the reason for missed messages by emitting metrics about
> each queue's size.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)