[
https://issues.apache.org/jira/browse/GOBBLIN-1934?focusedWorklogId=887061&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-887061
]
ASF GitHub Bot logged work on GOBBLIN-1934:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 24/Oct/23 18:58
Start Date: 24/Oct/23 18:58
Worklog Time Spent: 10m
Work Description: phet commented on code in PR #3805:
URL: https://github.com/apache/gobblin/pull/3805#discussion_r1370689487
##########
gobblin-service/src/main/java/org/apache/gobblin/service/monitoring/DagActionStoreChangeMonitor.java:
##########
@@ -219,10 +218,11 @@ protected void submitFlowToDagManagerHelper(String
flowGroup, String flowName) {
protected void createMetrics() {
super.messagesRead =
this.getMetricContext().counter(RuntimeMetrics.DAG_ACTION_STORE_MONITOR_PREFIX
+ "." + RuntimeMetrics.GOBBLIN_KAFKA_HIGH_LEVEL_CONSUMER_MESSAGES_READ);
super.queueSizeGauges = new ContextAwareGauge[super.numThreads];
- for (int i=0; i < numThreads; i++) {
+ for (int i = 0; i < numThreads; i++) {
// An 'effectively' final variable is needed inside the lambda
expression below
int finalI = i;
this.queueSizeGauges[i] = this.getMetricContext().newContextAwareGauge(
+ RuntimeMetrics.DAG_ACTION_STORE_MONITOR_PREFIX + "." +
Review Comment:
couldn't we just define a method:
```
protected String getMetricsPrefix()
```
and have `super.createMetrics()` call that to make this minor adjustment,
rather than basically copying and pasting the def w/ only a slight change?
##########
gobblin-runtime/src/main/java/org/apache/gobblin/runtime/kafka/HighLevelConsumer.java:
##########
@@ -130,7 +129,7 @@ public HighLevelConsumer(String topic, Config config, int
numThreads) {
this.consumerExecutor =
Executors.newSingleThreadScheduledExecutor(ExecutorsUtils.newThreadFactory(Optional.of(log),
Optional.of("HighLevelConsumerThread")));
this.queueExecutor = Executors.newFixedThreadPool(this.numThreads,
ExecutorsUtils.newThreadFactory(Optional.of(log),
Optional.of("QueueProcessor-%d")));
this.queues = new LinkedBlockingQueue[numThreads];
- for(int i=0; i<queues.length; i++) {
+ for(int i = 0; i<queues.length; i++) {
Review Comment:
now we have spaces issue w/ `i < queues.length`
Issue Time Tracking
-------------------
Worklog Id: (was: 887061)
Time Spent: 1h 40m (was: 1.5h)
> Monitor High Level Consumer queue size
> --------------------------------------
>
> Key: GOBBLIN-1934
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1934
> Project: Apache Gobblin
> Issue Type: Improvement
> Components: gobblin-service
> Reporter: Urmi Mustafi
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> We suspect that the HighLevelConsumer class may be dropping Kafka messages if
> the thread for a particular consumption queue is interrupted or stalled.
> Before changing how these queues are handled, we want to verify that blocked
> or dropped queues is the reason for missed messages by emitting metrics about
> each queue's size.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)