[
https://issues.apache.org/jira/browse/GOBBLIN-1934?focusedWorklogId=887065&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-887065
]
ASF GitHub Bot logged work on GOBBLIN-1934:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 24/Oct/23 20:04
Start Date: 24/Oct/23 20:04
Worklog Time Spent: 10m
Work Description: umustafi commented on code in PR #3805:
URL: https://github.com/apache/gobblin/pull/3805#discussion_r1370755222
##########
gobblin-runtime/src/main/java/org/apache/gobblin/runtime/kafka/HighLevelConsumer.java:
##########
@@ -130,7 +129,7 @@ public HighLevelConsumer(String topic, Config config, int
numThreads) {
this.consumerExecutor =
Executors.newSingleThreadScheduledExecutor(ExecutorsUtils.newThreadFactory(Optional.of(log),
Optional.of("HighLevelConsumerThread")));
this.queueExecutor = Executors.newFixedThreadPool(this.numThreads,
ExecutorsUtils.newThreadFactory(Optional.of(log),
Optional.of("QueueProcessor-%d")));
this.queues = new LinkedBlockingQueue[numThreads];
- for(int i=0; i<queues.length; i++) {
+ for(int i = 0; i<queues.length; i++) {
Review Comment:
good callout, this was the original code actually but adding the spacing.
Issue Time Tracking
-------------------
Worklog Id: (was: 887065)
Time Spent: 2h (was: 1h 50m)
> Monitor High Level Consumer queue size
> --------------------------------------
>
> Key: GOBBLIN-1934
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1934
> Project: Apache Gobblin
> Issue Type: Improvement
> Components: gobblin-service
> Reporter: Urmi Mustafi
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 2h
> Remaining Estimate: 0h
>
> We suspect that the HighLevelConsumer class may be dropping Kafka messages if
> the thread for a particular consumption queue is interrupted or stalled.
> Before changing how these queues are handled, we want to verify that blocked
> or dropped queues is the reason for missed messages by emitting metrics about
> each queue's size.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)