[
https://issues.apache.org/jira/browse/GOBBLIN-1934?focusedWorklogId=887067&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-887067
]
ASF GitHub Bot logged work on GOBBLIN-1934:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 24/Oct/23 20:16
Start Date: 24/Oct/23 20:16
Worklog Time Spent: 10m
Work Description: phet commented on code in PR #3805:
URL: https://github.com/apache/gobblin/pull/3805#discussion_r1370765305
##########
gobblin-runtime/src/main/java/org/apache/gobblin/runtime/kafka/HighLevelConsumer.java:
##########
@@ -196,7 +198,24 @@ protected void shutdownMetrics() throws IOException {
* this method to instantiate their own metrics.
*/
protected void createMetrics() {
- this.messagesRead =
this.metricContext.counter(RuntimeMetrics.GOBBLIN_KAFKA_HIGH_LEVEL_CONSUMER_MESSAGES_READ);
+ String prefix = getMetricsPrefix();
+ this.messagesRead = this.metricContext.counter(prefix +
+ RuntimeMetrics.GOBBLIN_KAFKA_HIGH_LEVEL_CONSUMER_MESSAGES_READ);
+ this.queueSizeGauges = new ContextAwareGauge[numThreads];
+ for (int i=0; i < numThreads; i++) {
Review Comment:
oops, one more `i=0` (spaces)
Issue Time Tracking
-------------------
Worklog Id: (was: 887067)
Time Spent: 2h 20m (was: 2h 10m)
> Monitor High Level Consumer queue size
> --------------------------------------
>
> Key: GOBBLIN-1934
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1934
> Project: Apache Gobblin
> Issue Type: Improvement
> Components: gobblin-service
> Reporter: Urmi Mustafi
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> We suspect that the HighLevelConsumer class may be dropping Kafka messages if
> the thread for a particular consumption queue is interrupted or stalled.
> Before changing how these queues are handled, we want to verify that blocked
> or dropped queues is the reason for missed messages by emitting metrics about
> each queue's size.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)