phet commented on code in PR #3808:
URL: https://github.com/apache/gobblin/pull/3808#discussion_r1372425872
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/FlowTriggerHandler.java:
##########
@@ -79,6 +79,7 @@ public class FlowTriggerHandler {
private ContextAwareCounter noLongerLeasingStatusCount;
private ContextAwareCounter jobDoesNotExistInSchedulerCount;
private ContextAwareCounter failedToSetEventReminderCount;
+ private ContextAwareMeter numRemindersDoingMissedWork;
Review Comment:
this name over-interprets ("missed" vs. "unfinished"; "doing" vs.
"attempting").
if we stuck "strictly to the facts", could we say
`numLeasesObtainedDueToReminder`?
...hey, wait! ...although I do prefer the `num` prefix, I see the convention
above seems instead to be the `Count` suffix. so maybe
`leaseObtainedUponReminderCount`?
##########
gobblin-service/src/main/java/org/apache/gobblin/service/monitoring/DagActionStoreChangeMonitor.java:
##########
@@ -143,6 +135,15 @@ protected void processMessage(DecodeableKafkaRecord
message) {
return;
}
+ // Needs to be done after, filtering out heartbeat values that do have
valid null dagActionTypes
+ if (value.getDagAction() == null) {
Review Comment:
at first, I couldn't figure out "after" what? is this accurate rephrasing?
```
// check after `shouldProcessMessage` filters out heartbeat messages (w/
`dagActionType == null`)
```
another way to help indicate would be to replace `if` w/ `else if`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]