Will-Lo commented on code in PR #3808:
URL: https://github.com/apache/gobblin/pull/3808#discussion_r1372412643
##########
gobblin-metrics-libs/gobblin-metrics/src/main/java/org/apache/gobblin/metrics/ServiceMetricNames.java:
##########
@@ -35,13 +35,14 @@ public class ServiceMetricNames {
public static final String FLOW_ORCHESTRATION_DELAY = GOBBLIN_SERVICE_PREFIX
+ ".flowOrchestration.delay";
// Flow Trigger Handler
- public static final String FLOW_TRIGGER_HANDLER_PREFIX =
"flowTriggerHandler";
- public static final String GOBBLIN_FLOW_TRIGGER_HANDLER_NUM_FLOWS_SUBMITTED
= ServiceMetricNames.GOBBLIN_SERVICE_PREFIX + "." + FLOW_TRIGGER_HANDLER_PREFIX
+ ".numFlowsSubmitted";
- public static final String FLOW_TRIGGER_HANDLER_LEASE_OBTAINED_COUNT =
GOBBLIN_SERVICE_PREFIX + "." + FLOW_TRIGGER_HANDLER_PREFIX + ".leaseObtained";
- public static final String FLOW_TRIGGER_HANDLER_LEASED_TO_ANOTHER_COUNT =
GOBBLIN_SERVICE_PREFIX + "." + FLOW_TRIGGER_HANDLER_PREFIX + ".leasedToAnother";
- public static final String FLOW_TRIGGER_HANDLER_NO_LONGER_LEASING_COUNT =
GOBBLIN_SERVICE_PREFIX + "." + FLOW_TRIGGER_HANDLER_PREFIX + ".noLongerLeasing";
- public static final String FLOW_TRIGGER_HANDLER_JOB_DOES_NOT_EXIST_COUNT =
GOBBLIN_SERVICE_PREFIX + "." + FLOW_TRIGGER_HANDLER_PREFIX +
".jobDoesNotExistInScheduler";
- public static final String FLOW_TRIGGER_HANDLER_FAILED_TO_SET_REMINDER_COUNT
= GOBBLIN_SERVICE_PREFIX + "." + FLOW_TRIGGER_HANDLER_PREFIX +
".failedToSetReminderCount";
+ public static final String FLOW_TRIGGER_HANDLER_PREFIX =
GOBBLIN_SERVICE_PREFIX + "." + "flowTriggerHandler";
Review Comment:
Is it possible for us to add the dot to the GOBBLIN_SERVICE_PREFIX and
remove manually adding the dots in subsequent metric names? Might be a pain to
do but I think this will lead to a better codebase where this keeps getting
missed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]