umustafi commented on PR #3808:
URL: https://github.com/apache/gobblin/pull/3808#issuecomment-1781871683

   Tried to add a unit test for `DagActionStoreMonitor.processMessage` to 
ensure that `heartbeat` messages or null `dagActionType` messages are processed 
in the correct order but these tests will need to be e2e tests that instantiate 
a `DagActionStoreMonitor` instance, created DecodeableKafkaRecords, and can 
properly parse a variety of messages (insert, delete, heartbeat, etc...) but 
it's going to be a bigger change and LOE than the scope of the current PR. I 
will follow up with a separate PR for that. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to