[
https://issues.apache.org/jira/browse/GOBBLIN-1952?focusedWorklogId=889130&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-889130
]
ASF GitHub Bot logged work on GOBBLIN-1952:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 07/Nov/23 02:45
Start Date: 07/Nov/23 02:45
Worklog Time Spent: 10m
Work Description: Will-Lo opened a new pull request, #3822:
URL: https://github.com/apache/gobblin/pull/3822
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I
have checked off all the steps below!
### JIRA
- [ ] My PR addresses the following [Gobblin
JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references
them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-XXX
### Description
- [ ] Here are some details about my PR, including screenshots (if
applicable):
Gobblin-as-a-Service creates jobnames using flowgroups flownames, edges, and
jobnames from the template. However, this tends to create a very long string
which then causes issues in Gobblin job when creating files that use the
jobname to create working directories or state stores.
Although there has been previous code that shortens job name lengths, we
want to further increase this by being more aggressive with the maximum length
of the jobname to reduce the odds of exceeding 255 chars (max length of HDFS
component)
The PR reduces the max job name length to 128 characters (1/2 of previous
max) as well as forcing jobnames to then be shortened to `flowGroup_<job_hash>`
which will be a UUID at a per-job level for each dag.
The reason why it uses flowGroup still as a prefix before the jobname hash
is to reduce the odds that a shared job working directory will run into hash
collisions, which can lead to complications on concurrent jobs
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
### Commits
- [ ] My commits all reference JIRA issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
Issue Time Tracking
-------------------
Worklog Id: (was: 889130)
Remaining Estimate: 0h
Time Spent: 10m
> GaaS JobNames with long lengths cause issues with HDFS folders
> --------------------------------------------------------------
>
> Key: GOBBLIN-1952
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1952
> Project: Apache Gobblin
> Issue Type: Bug
> Components: gobblin-service
> Reporter: William Lo
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Gobblin-as-a-Service creates jobnames using flowgroups flownames, edges, and
> jobnames from the template. However, this tends to create a very long string
> which then causes issues in Gobblin job when creating files that use the
> jobname to create working directories or state stores. Although there has
> been previous code that shortens job name lengths, we want to further
> increase this by being more aggressive with the maximum length of the jobname
> to reduce the odds of exceeding 255 chars (max length of HDFS component)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
