[
https://issues.apache.org/jira/browse/GOBBLIN-1952?focusedWorklogId=889139&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-889139
]
ASF GitHub Bot logged work on GOBBLIN-1952:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 07/Nov/23 03:06
Start Date: 07/Nov/23 03:06
Worklog Time Spent: 10m
Work Description: codecov-commenter commented on PR #3822:
URL: https://github.com/apache/gobblin/pull/3822#issuecomment-1797394857
##
[Codecov](https://app.codecov.io/gh/apache/gobblin/pull/3822?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
Report
> Merging
[#3822](https://app.codecov.io/gh/apache/gobblin/pull/3822?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
(38b9be7) into
[master](https://app.codecov.io/gh/apache/gobblin/commit/96092f75d34d5839c9b72fc75fdea87c84e93b62?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
(96092f7) will **increase** coverage by `5.96%`.
> Report is 5 commits behind head on master.
> The diff coverage is `100.00%`.
```diff
@@ Coverage Diff @@
## master #3822 +/- ##
============================================
+ Coverage 47.63% 53.60% +5.96%
+ Complexity 11048 1399 -9649
============================================
Files 2155 281 -1874
Lines 85325 10343 -74982
Branches 9488 1110 -8378
============================================
- Hits 40642 5544 -35098
+ Misses 40994 4279 -36715
+ Partials 3689 520 -3169
```
|
[Files](https://app.codecov.io/gh/apache/gobblin/pull/3822?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
| Coverage Δ | |
|---|---|---|
|
[...gobblin/service/modules/spec/JobExecutionPlan.java](https://app.codecov.io/gh/apache/gobblin/pull/3822?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z29iYmxpbi1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9kdWxlcy9zcGVjL0pvYkV4ZWN1dGlvblBsYW4uamF2YQ==)
| `69.87% <100.00%> (ø)` | |
... and [1878 files with indirect coverage
changes](https://app.codecov.io/gh/apache/gobblin/pull/3822/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: Codecov offers a browser extension for seamless coverage viewing on
GitHub. Try it in
[Chrome](https://chrome.google.com/webstore/detail/codecov/gedikamndpbemklijjkncpnolildpbgo)
or [Firefox](https://addons.mozilla.org/en-US/firefox/addon/codecov/) today!
Issue Time Tracking
-------------------
Worklog Id: (was: 889139)
Time Spent: 20m (was: 10m)
> GaaS JobNames with long lengths cause issues with HDFS folders
> --------------------------------------------------------------
>
> Key: GOBBLIN-1952
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1952
> Project: Apache Gobblin
> Issue Type: Bug
> Components: gobblin-service
> Reporter: William Lo
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Gobblin-as-a-Service creates jobnames using flowgroups flownames, edges, and
> jobnames from the template. However, this tends to create a very long string
> which then causes issues in Gobblin job when creating files that use the
> jobname to create working directories or state stores. Although there has
> been previous code that shortens job name lengths, we want to further
> increase this by being more aggressive with the maximum length of the jobname
> to reduce the odds of exceeding 255 chars (max length of HDFS component)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
