[ 
https://issues.apache.org/jira/browse/GOBBLIN-1952?focusedWorklogId=889322&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-889322
 ]

ASF GitHub Bot logged work on GOBBLIN-1952:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 07/Nov/23 18:43
            Start Date: 07/Nov/23 18:43
    Worklog Time Spent: 10m 
      Work Description: umustafi commented on code in PR #3822:
URL: https://github.com/apache/gobblin/pull/3822#discussion_r1385396488


##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/spec/JobExecutionPlan.java:
##########
@@ -112,10 +112,10 @@ private static JobSpec buildJobSpec(FlowSpec flowSpec, 
Config jobConfig, Long fl
       // job names are assumed to be unique within a dag.
       int hash = flowInputPath.hashCode();

Review Comment:
   Should we still hash this one or use the whole path in jobName and then only 
hash that? Similar to Arjun's comment





Issue Time Tracking
-------------------

    Worklog Id:     (was: 889322)
    Time Spent: 1h  (was: 50m)

> GaaS JobNames with long lengths cause issues with HDFS folders
> --------------------------------------------------------------
>
>                 Key: GOBBLIN-1952
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-1952
>             Project: Apache Gobblin
>          Issue Type: Bug
>          Components: gobblin-service
>            Reporter: William Lo
>            Assignee: Abhishek Tiwari
>            Priority: Major
>          Time Spent: 1h
>  Remaining Estimate: 0h
>
> Gobblin-as-a-Service creates jobnames using flowgroups flownames, edges, and 
> jobnames from the template. However, this tends to create a very long string 
> which then causes issues in Gobblin job when creating files that use the 
> jobname to create working directories or state stores. Although there has 
> been previous code that shortens job name lengths, we want to further 
> increase this by being more aggressive with the maximum length of the jobname 
> to reduce the odds of exceeding 255 chars (max length of HDFS component)



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to