[
https://issues.apache.org/jira/browse/GOBBLIN-1958?focusedWorklogId=890834&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-890834
]
ASF GitHub Bot logged work on GOBBLIN-1958:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 16/Nov/23 00:57
Start Date: 16/Nov/23 00:57
Worklog Time Spent: 10m
Work Description: phet opened a new pull request, #3830:
URL: https://github.com/apache/gobblin/pull/3830
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I
have checked off all the steps below!
### JIRA
- [ ] My PR addresses the following [Gobblin
JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references
them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-1958
### Description
- [ ] Here are some details about my PR, including screenshots (if
applicable):
The current /flowexecutions implementation treats the presence of a pending
action differently between RESUME and KILL: for the former it gives HTTP 409
Conflict and the latter gives HTTP 400 Bad Request.
1. fix so it is 409 in both cases
2. in all error handling, forward any message to include in the
`RestLiServiceException` (it had been dropped when 400)
3. combine the impls between RESUME and KILL to ensure consistency
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
existing unit tests
### Commits
- [ ] My commits all reference JIRA issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
4. Subject is limited to 50 characters
5. Subject does not end with a period
6. Subject uses the imperative mood ("add", not "adding")
7. Body wraps at 72 characters
8. Body explains "what" and "why", not "how"
Issue Time Tracking
-------------------
Worklog Id: (was: 890834)
Remaining Estimate: 0h
Time Spent: 10m
> Fix /flowexecutions KILL action to return HTTP 409 when already a pending
> action, not 400
> -----------------------------------------------------------------------------------------
>
> Key: GOBBLIN-1958
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1958
> Project: Apache Gobblin
> Issue Type: Improvement
> Components: gobblin-restli
> Reporter: Kip Kohn
> Assignee: Hung Tran
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> when already a pending action, the current implementation returns 409 for
> RESUME, and 400 for KILL. furthermore it provides no message to the user.
>
> this looks like a bug introduced during recent feature development and/or
> refactoring
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
