[
https://issues.apache.org/jira/browse/GOBBLIN-1958?focusedWorklogId=890987&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-890987
]
ASF GitHub Bot logged work on GOBBLIN-1958:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 16/Nov/23 17:03
Start Date: 16/Nov/23 17:03
Worklog Time Spent: 10m
Work Description: Will-Lo commented on code in PR #3830:
URL: https://github.com/apache/gobblin/pull/3830#discussion_r1396058846
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/restli/GobblinServiceFlowExecutionResourceHandlerWithWarmStandby.java:
##########
@@ -46,56 +48,38 @@ public
GobblinServiceFlowExecutionResourceHandlerWithWarmStandby(FlowExecutionRe
this.dagActionStore = dagActionStore;
}
+ @Override
+ public void resume(ComplexResourceKey<FlowStatusId, EmptyRecord> key) {
+ FlowStatusId id = key.getKey();
+ addDagAction(id.getFlowGroup(), id.getFlowName(), id.getFlowExecutionId(),
DagActionStore.FlowActionType.RESUME);
+ }
Review Comment:
I know this is sort of how the class was designed, but I'm curious why we
also don't return a 200 OK response for resume.
Also I'm wondering why we don't enforce that the dag exists before we
attempt to kill/resume it, seems like it is a source for some pain in users
Issue Time Tracking
-------------------
Worklog Id: (was: 890987)
Time Spent: 20m (was: 10m)
> Fix /flowexecutions KILL action to return HTTP 409 when already a pending
> action, not 400
> -----------------------------------------------------------------------------------------
>
> Key: GOBBLIN-1958
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1958
> Project: Apache Gobblin
> Issue Type: Improvement
> Components: gobblin-restli
> Reporter: Kip Kohn
> Assignee: Hung Tran
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> when already a pending action, the current implementation returns 409 for
> RESUME, and 400 for KILL. furthermore it provides no message to the user.
>
> this looks like a bug introduced during recent feature development and/or
> refactoring
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
