[
https://issues.apache.org/jira/browse/GOBBLIN-1958?focusedWorklogId=890988&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-890988
]
ASF GitHub Bot logged work on GOBBLIN-1958:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 16/Nov/23 17:09
Start Date: 16/Nov/23 17:09
Worklog Time Spent: 10m
Work Description: codecov-commenter commented on PR #3830:
URL: https://github.com/apache/gobblin/pull/3830#issuecomment-1814872927
##
[Codecov](https://app.codecov.io/gh/apache/gobblin/pull/3830?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
Report
All modified and coverable lines are covered by tests :white_check_mark:
> Comparison is base
[(`dd17bed`)](https://app.codecov.io/gh/apache/gobblin/commit/dd17bed4367addd9c68608e2795ffae2d08434b6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
47.53% compared to head
[(`7113818`)](https://app.codecov.io/gh/apache/gobblin/pull/3830?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
46.00%.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #3830 +/- ##
============================================
- Coverage 47.53% 46.00% -1.53%
+ Complexity 11035 2181 -8854
============================================
Files 2156 416 -1740
Lines 85377 17984 -67393
Branches 9491 2194 -7297
============================================
- Hits 40581 8273 -32308
+ Misses 41099 8827 -32272
+ Partials 3697 884 -2813
```
</details>
[:umbrella: View full report in Codecov by
Sentry](https://app.codecov.io/gh/apache/gobblin/pull/3830?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it
here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
Issue Time Tracking
-------------------
Worklog Id: (was: 890988)
Time Spent: 0.5h (was: 20m)
> Fix /flowexecutions KILL action to return HTTP 409 when already a pending
> action, not 400
> -----------------------------------------------------------------------------------------
>
> Key: GOBBLIN-1958
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1958
> Project: Apache Gobblin
> Issue Type: Improvement
> Components: gobblin-restli
> Reporter: Kip Kohn
> Assignee: Hung Tran
> Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> when already a pending action, the current implementation returns 409 for
> RESUME, and 400 for KILL. furthermore it provides no message to the user.
>
> this looks like a bug introduced during recent feature development and/or
> refactoring
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
