[
https://issues.apache.org/jira/browse/GOBBLIN-1961?focusedWorklogId=891596&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-891596
]
ASF GitHub Bot logged work on GOBBLIN-1961:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 21/Nov/23 16:13
Start Date: 21/Nov/23 16:13
Worklog Time Spent: 10m
Work Description: codecov-commenter commented on PR #3834:
URL: https://github.com/apache/gobblin/pull/3834#issuecomment-1821229473
##
[Codecov](https://app.codecov.io/gh/apache/gobblin/pull/3834?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
Report
All modified and coverable lines are covered by tests :white_check_mark:
> Comparison is base
[(`70e480f`)](https://app.codecov.io/gh/apache/gobblin/commit/70e480fe74ff37f6d7cdacbde8945095a55169ff?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
47.55% compared to head
[(`f0d7a0f`)](https://app.codecov.io/gh/apache/gobblin/pull/3834?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
45.98%.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #3834 +/- ##
============================================
- Coverage 47.55% 45.98% -1.57%
+ Complexity 11037 2178 -8859
============================================
Files 2156 416 -1740
Lines 85381 17984 -67397
Branches 9489 2194 -7295
============================================
- Hits 40601 8270 -32331
+ Misses 41082 8830 -32252
+ Partials 3698 884 -2814
```
</details>
[:umbrella: View full report in Codecov by
Sentry](https://app.codecov.io/gh/apache/gobblin/pull/3834?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it
here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
Issue Time Tracking
-------------------
Worklog Id: (was: 891596)
Time Spent: 20m (was: 10m)
> Qualify IcebergTable DatasetDescriptors (used by Iceberg-Distcp)
> ----------------------------------------------------------------
>
> Key: GOBBLIN-1961
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1961
> Project: Apache Gobblin
> Issue Type: Improvement
> Components: gobblin-compliance
> Reporter: Kip Kohn
> Assignee: Issac Buenrostro
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> `IcebergTable.getDatasetDescriptor` currently uses only the table name,
> although it should be qualified by the DB (source or destination,
> respectively)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)