[
https://issues.apache.org/jira/browse/GOBBLIN-1961?focusedWorklogId=891688&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-891688
]
ASF GitHub Bot logged work on GOBBLIN-1961:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 22/Nov/23 02:19
Start Date: 22/Nov/23 02:19
Worklog Time Spent: 10m
Work Description: phet commented on code in PR #3835:
URL: https://github.com/apache/gobblin/pull/3835#discussion_r1401418443
##########
gobblin-data-management/src/main/java/org/apache/gobblin/data/management/copy/iceberg/IcebergDataset.java:
##########
@@ -63,10 +63,8 @@
@Slf4j
@Getter
public class IcebergDataset implements PrioritizedCopyableDataset {
- private final String dbName;
- private final String inputTableName;
private final IcebergTable srcIcebergTable;
- /** Presumed destination {@link IcebergTable} exists */
+ /* CAUTION: *hopefully* `destIcebergTable` exists... although that's not
necessarily been verified yet */
Review Comment:
for some catalogs, like openhouse, that's not actually possible: the tables
must have been already mated in a way that we are unable to accomplish
ourselves (i.e. from outside the catalog itself)
Issue Time Tracking
-------------------
Worklog Id: (was: 891688)
Time Spent: 1h 40m (was: 1.5h)
> Qualify IcebergTable DatasetDescriptors (used by Iceberg-Distcp)
> ----------------------------------------------------------------
>
> Key: GOBBLIN-1961
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1961
> Project: Apache Gobblin
> Issue Type: Improvement
> Components: gobblin-compliance
> Reporter: Kip Kohn
> Assignee: Issac Buenrostro
> Priority: Major
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> `IcebergTable.getDatasetDescriptor` currently uses only the table name,
> although it should be qualified by the DB (source or destination,
> respectively)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
