[
https://issues.apache.org/jira/browse/GOBBLIN-1961?focusedWorklogId=891687&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-891687
]
ASF GitHub Bot logged work on GOBBLIN-1961:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 22/Nov/23 02:19
Start Date: 22/Nov/23 02:19
Worklog Time Spent: 10m
Work Description: phet commented on code in PR #3835:
URL: https://github.com/apache/gobblin/pull/3835#discussion_r1401423357
##########
gobblin-data-management/src/main/java/org/apache/gobblin/data/management/copy/iceberg/IcebergDataset.java:
##########
@@ -117,17 +113,17 @@ public Iterator<FileSet<CopyEntity>>
getFileSetIterator(FileSystem targetFs, Cop
return createFileSets(targetFs, configuration);
}
- /** @return unique ID for this dataset, usable as a {@link
CopyEntity}.fileset, for atomic publication grouping */
+ /** @return unique ID for dataset (based on the source-side table), usable
as a {@link CopyEntity#getFileSet}, for atomic publication grouping */
protected String getFileSetId() {
Review Comment:
the name originally arose because it's the value provided to the
`CopyableFile.Builder.fileSet` setter -
https://github.com/apache/gobblin/pull/3835/files#diff-da31b49b793e970e5d99d51f52c63d592a6b7dfd8b18d8cc988cd52a9521d478R155
does it make more sense in context, or do you still recommend to change?
Issue Time Tracking
-------------------
Worklog Id: (was: 891687)
Time Spent: 1.5h (was: 1h 20m)
> Qualify IcebergTable DatasetDescriptors (used by Iceberg-Distcp)
> ----------------------------------------------------------------
>
> Key: GOBBLIN-1961
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1961
> Project: Apache Gobblin
> Issue Type: Improvement
> Components: gobblin-compliance
> Reporter: Kip Kohn
> Assignee: Issac Buenrostro
> Priority: Major
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> `IcebergTable.getDatasetDescriptor` currently uses only the table name,
> although it should be qualified by the DB (source or destination,
> respectively)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
