[ 
https://issues.apache.org/jira/browse/GOBBLIN-1974?focusedWorklogId=895543&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-895543
 ]

ASF GitHub Bot logged work on GOBBLIN-1974:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 13/Dec/23 20:23
            Start Date: 13/Dec/23 20:23
    Worklog Time Spent: 10m 
      Work Description: codecov-commenter commented on PR #3846:
URL: https://github.com/apache/gobblin/pull/3846#issuecomment-1854650106

   ## 
[Codecov](https://app.codecov.io/gh/apache/gobblin/pull/3846?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 Report
   All modified and coverable lines are covered by tests :white_check_mark:
   > Comparison is base 
[(`00c60ca`)](https://app.codecov.io/gh/apache/gobblin/commit/00c60ca6492644652c66905eb384ab145e348bbf?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 42.61% compared to head 
[(`a60aa94`)](https://app.codecov.io/gh/apache/gobblin/pull/3846?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 38.68%.
   
   
   <details><summary>Additional details and impacted files</summary>
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #3846      +/-   ##
   ============================================
   - Coverage     42.61%   38.68%   -3.94%     
   + Complexity     3779     1596    -2183     
   ============================================
     Files           804      388     -416     
     Lines         33940    15948   -17992     
     Branches       3769     1575    -2194     
   ============================================
   - Hits          14463     6169    -8294     
   + Misses        18103     9289    -8814     
   + Partials       1374      490     -884     
   ```
   
   
   
   </details>
   
   [:umbrella: View full report in Codecov by 
Sentry](https://app.codecov.io/gh/apache/gobblin/pull/3846?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   
   :loudspeaker: Have feedback on the report? [Share it 
here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   




Issue Time Tracking
-------------------

    Worklog Id:     (was: 895543)
    Time Spent: 40m  (was: 0.5h)

> Ensure Adhoc Flows can be Executed in Multi-active Scheduler state
> ------------------------------------------------------------------
>
>                 Key: GOBBLIN-1974
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-1974
>             Project: Apache Gobblin
>          Issue Type: Bug
>          Components: gobblin-service
>            Reporter: Urmi Mustafi
>            Assignee: Abhishek Tiwari
>            Priority: Major
>          Time Spent: 40m
>  Remaining Estimate: 0h
>
> Adhoc flow executions delete the flow spec from the FlowCatalog after adding 
> the spec to the scheduler for the single active scheduler. This makes sense 
> in prior context since the single active scheduler has the information and 
> the spec is no longer needed. However, in the multi-active case we run into a 
> {{No spec found}} error here 
> [https://github.com/apache/gobblin/blob/00c60ca6492644652c66905eb384ab145e348bbf/gobblin-service/src/main/java/org/apache/gobblin/service/monitoring/DagActionStoreChangeMonitor.java#L263].
>  This PR updates the code to delete the spec after persisting it in the adhoc 
> execution case. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to