[
https://issues.apache.org/jira/browse/GOBBLIN-1974?focusedWorklogId=895567&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-895567
]
ASF GitHub Bot logged work on GOBBLIN-1974:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 14/Dec/23 00:46
Start Date: 14/Dec/23 00:46
Worklog Time Spent: 10m
Work Description: arjun4084346 commented on code in PR #3846:
URL: https://github.com/apache/gobblin/pull/3846#discussion_r1426028845
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/Orchestrator.java:
##########
@@ -359,6 +374,13 @@ public void submitFlowToDagManager(FlowSpec flowSpec,
Dag<JobExecutionPlan> jobE
try {
// Send the dag to the DagManager
this.dagManager.get().addDag(jobExecutionPlanDag, true, true);
+
+ /*
+ Adhoc flows can be deleted after persisting it in DagManager as the
DagManager's failure recovery method ensures
+ it will be executed in the event of downtime. Note that the
responsibility of the multi-active scheduler mode ends
+ after this method is completed AND the consumption of a launch type
event is committed to the consumer.
+ */
+ deleteSpecFromCatalogIfAdhoc(flowSpec);
Review Comment:
To confirm, did you check the callers of `FlowCatalog` `remove` method ? Is
it missing some case?
Issue Time Tracking
-------------------
Worklog Id: (was: 895567)
Time Spent: 1.5h (was: 1h 20m)
> Ensure Adhoc Flows can be Executed in Multi-active Scheduler state
> ------------------------------------------------------------------
>
> Key: GOBBLIN-1974
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1974
> Project: Apache Gobblin
> Issue Type: Bug
> Components: gobblin-service
> Reporter: Urmi Mustafi
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> Adhoc flow executions delete the flow spec from the FlowCatalog after adding
> the spec to the scheduler for the single active scheduler. This makes sense
> in prior context since the single active scheduler has the information and
> the spec is no longer needed. However, in the multi-active case we run into a
> {{No spec found}} error here
> [https://github.com/apache/gobblin/blob/00c60ca6492644652c66905eb384ab145e348bbf/gobblin-service/src/main/java/org/apache/gobblin/service/monitoring/DagActionStoreChangeMonitor.java#L263].
> This PR updates the code to delete the spec after persisting it in the adhoc
> execution case.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
