[
https://issues.apache.org/jira/browse/GOBBLIN-1974?focusedWorklogId=895714&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-895714
]
ASF GitHub Bot logged work on GOBBLIN-1974:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 14/Dec/23 19:43
Start Date: 14/Dec/23 19:43
Worklog Time Spent: 10m
Work Description: phet commented on code in PR #3846:
URL: https://github.com/apache/gobblin/pull/3846#discussion_r1427191544
##########
gobblin-service/src/test/java/org/apache/gobblin/service/GobblinServiceManagerTest.java:
##########
@@ -346,13 +346,14 @@ public void testRunQuotaExceeds() throws Exception {
@Test (dependsOnMethods = "testRunQuotaExceeds")
public void testExplainJob() throws Exception {
+ int sizeBeforeTest =
this.gobblinServiceManager.getFlowCatalog().getSpecs().size();
FlowConfig flowConfig = new FlowConfig().setId(new
FlowId().setFlowGroup(TEST_GROUP_NAME).setFlowName(TEST_FLOW_NAME))
.setTemplateUris(TEST_TEMPLATE_URI).setProperties(new
StringMap(flowProperties)).setExplain(true);
this.flowConfigClient.createFlowConfig(flowConfig);
// explain job should not be persisted
-
Assert.assertEquals(this.gobblinServiceManager.getFlowCatalog().getSpecs().size(),
0);
+
Assert.assertEquals(this.gobblinServiceManager.getFlowCatalog().getSpecs().size(),
sizeBeforeTest);
Review Comment:
does this presume a single-threaded test runner? if so, was that already
configured prior to this PR?
Issue Time Tracking
-------------------
Worklog Id: (was: 895714)
Time Spent: 2h 20m (was: 2h 10m)
> Ensure Adhoc Flows can be Executed in Multi-active Scheduler state
> ------------------------------------------------------------------
>
> Key: GOBBLIN-1974
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1974
> Project: Apache Gobblin
> Issue Type: Bug
> Components: gobblin-service
> Reporter: Urmi Mustafi
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> Adhoc flow executions delete the flow spec from the FlowCatalog after adding
> the spec to the scheduler for the single active scheduler. This makes sense
> in prior context since the single active scheduler has the information and
> the spec is no longer needed. However, in the multi-active case we run into a
> {{No spec found}} error here
> [https://github.com/apache/gobblin/blob/00c60ca6492644652c66905eb384ab145e348bbf/gobblin-service/src/main/java/org/apache/gobblin/service/monitoring/DagActionStoreChangeMonitor.java#L263].
> This PR updates the code to delete the spec after persisting it in the adhoc
> execution case.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
