[
https://issues.apache.org/jira/browse/GOBBLIN-1984?focusedWorklogId=899304&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-899304
]
ASF GitHub Bot logged work on GOBBLIN-1984:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 12/Jan/24 00:37
Start Date: 12/Jan/24 00:37
Worklog Time Spent: 10m
Work Description: umustafi commented on code in PR #3857:
URL: https://github.com/apache/gobblin/pull/3857#discussion_r1449591489
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/utils/FlowCompilationValidationHelper.java:
##########
@@ -122,7 +119,7 @@ public Optional<Dag<JobExecutionPlan>>
validateAndHandleConcurrentExecution(Conf
sharedFlowMetricsSingleton.conditionallyUpdateFlowGaugeSpecState(spec,
SharedFlowMetricsSingleton.CompiledState.SKIPPED);
Instrumented.markMeter(sharedFlowMetricsSingleton.getSkippedFlowsMeter());
- if (!isScheduledFlow((FlowSpec) spec)) {
+ if (!((FlowSpec) spec).isScheduled()) {
Review Comment:
Good callout, from checking the code we only call these functions with a
FlowSpec and otherwise throw an error. Changing it to FlowSpec.
Issue Time Tracking
-------------------
Worklog Id: (was: 899304)
Time Spent: 40m (was: 0.5h)
> Add Consensus FlowExecutionId to FlowSpec used for Compilation and Tracking
> Dag
> -------------------------------------------------------------------------------
>
> Key: GOBBLIN-1984
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1984
> Project: Apache Gobblin
> Issue Type: Bug
> Components: gobblin-service
> Reporter: Urmi Mustafi
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
> In a previous change, we noticed the compiled flowExecutionId was different
> from the one during execution and tried to fix it by updating the
> flowMetadata used to send GTE relating to compilation. We succeeded in
> updating the compilation event to use the flowExecutionId but did not update
> the FlowSpec used by Compiler to create the Dag which is used during the
> execution phase of flow management. The compiler retrieves a flowExecutionId
> if one exists in the flowSpec (which it does for adhoc flows), otherwise
> generates a new one
> ([code|[https://jarvis.corp.linkedin.com/codesearch/result/?name=MultiHopFlowCompiler.java&path=gobblin-elr%2Fgobblin-service%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fgobblin%2Fservice%2Fmodules%2Fflow&reponame=linkedin%2Fgobblin-elr#301]).]
> We do need to modify the FlowSpec then with the consensus flowExecutionId
> before forwarding it to the DagManager.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)