[
https://issues.apache.org/jira/browse/GOBBLIN-1984?focusedWorklogId=899348&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-899348
]
ASF GitHub Bot logged work on GOBBLIN-1984:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 12/Jan/24 09:30
Start Date: 12/Jan/24 09:30
Worklog Time Spent: 10m
Work Description: phet commented on code in PR #3857:
URL: https://github.com/apache/gobblin/pull/3857#discussion_r1450112803
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/utils/FlowCompilationValidationHelper.java:
##########
@@ -104,35 +100,35 @@ public Optional<Dag<JobExecutionPlan>>
createExecutionPlanIfValid(FlowSpec flowS
/**
* Checks if flowSpec disallows concurrent executions, and if so then checks
if another instance of the flow is
* already running and emits a FLOW FAILED event. Otherwise, this check
passes.
- * @return Optional<Dag<JobExecutionPlan>> if caller allowed to execute flow
and compile spec, else absent Optional
+ * @return Optional<Dag<JobExecutionPlan>> if caller allowed to execute flow
and compile flowSpec, else absent Optional
Review Comment:
nit: "absent Optional" => `Optional.absent()`
##########
gobblin-service/src/main/java/org/apache/gobblin/service/monitoring/DagActionStoreChangeMonitor.java:
##########
@@ -276,8 +277,12 @@ protected void
submitFlowToDagManagerHelper(DagActionStore.DagAction dagAction,
try {
URI flowUri = FlowSpec.Utils.createFlowSpecUri(flowId);
spec = (FlowSpec) flowCatalog.getSpecs(flowUri);
Review Comment:
should `FlowCatalog.getSpecs` override w/ a covariant return type?
i.e. the `FlowSpec` in:
```
@Override
public FlowSpec getSpecs(URI uri) throws SpecNotFoundException {
```
##########
gobblin-runtime/src/main/java/org/apache/gobblin/runtime/api/FlowSpec.java:
##########
@@ -125,6 +128,19 @@ public static FlowSpec.Builder builder(URI catalogURI,
Properties flowProps) {
}
}
+ /**
+ * Add property to Config (also propagated to the Properties field)
+ * @param key
+ * @param value
+ */
+ public void addProperty(String key, String value) {
Review Comment:
since this modifies two fields, instances now require synchronization around
all access of either field
Issue Time Tracking
-------------------
Worklog Id: (was: 899348)
Time Spent: 1h (was: 50m)
> Add Consensus FlowExecutionId to FlowSpec used for Compilation and Tracking
> Dag
> -------------------------------------------------------------------------------
>
> Key: GOBBLIN-1984
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1984
> Project: Apache Gobblin
> Issue Type: Bug
> Components: gobblin-service
> Reporter: Urmi Mustafi
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 1h
> Remaining Estimate: 0h
>
> In a previous change, we noticed the compiled flowExecutionId was different
> from the one during execution and tried to fix it by updating the
> flowMetadata used to send GTE relating to compilation. We succeeded in
> updating the compilation event to use the flowExecutionId but did not update
> the FlowSpec used by Compiler to create the Dag which is used during the
> execution phase of flow management. The compiler retrieves a flowExecutionId
> if one exists in the flowSpec (which it does for adhoc flows), otherwise
> generates a new one
> ([code|[https://jarvis.corp.linkedin.com/codesearch/result/?name=MultiHopFlowCompiler.java&path=gobblin-elr%2Fgobblin-service%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fgobblin%2Fservice%2Fmodules%2Fflow&reponame=linkedin%2Fgobblin-elr#301]).]
> We do need to modify the FlowSpec then with the consensus flowExecutionId
> before forwarding it to the DagManager.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)