[
https://issues.apache.org/jira/browse/GOBBLIN-1984?focusedWorklogId=899305&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-899305
]
ASF GitHub Bot logged work on GOBBLIN-1984:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 12/Jan/24 00:55
Start Date: 12/Jan/24 00:55
Worklog Time Spent: 10m
Work Description: codecov-commenter commented on PR #3857:
URL: https://github.com/apache/gobblin/pull/3857#issuecomment-1888220028
##
[Codecov](https://app.codecov.io/gh/apache/gobblin/pull/3857?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
Report
All modified and coverable lines are covered by tests :white_check_mark:
> Comparison is base
[(`22248e4`)](https://app.codecov.io/gh/apache/gobblin/commit/22248e4f2b01859c7e833b99f6770a2d4bd15d6e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
47.56% compared to head
[(`6eaa5ca`)](https://app.codecov.io/gh/apache/gobblin/pull/3857?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
45.99%.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #3857 +/- ##
============================================
- Coverage 47.56% 45.99% -1.58%
+ Complexity 11068 2185 -8883
============================================
Files 2160 417 -1743
Lines 85563 18051 -67512
Branches 9509 2199 -7310
============================================
- Hits 40700 8302 -32398
+ Misses 41154 8865 -32289
+ Partials 3709 884 -2825
```
</details>
[:umbrella: View full report in Codecov by
Sentry](https://app.codecov.io/gh/apache/gobblin/pull/3857?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it
here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
Issue Time Tracking
-------------------
Worklog Id: (was: 899305)
Time Spent: 50m (was: 40m)
> Add Consensus FlowExecutionId to FlowSpec used for Compilation and Tracking
> Dag
> -------------------------------------------------------------------------------
>
> Key: GOBBLIN-1984
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1984
> Project: Apache Gobblin
> Issue Type: Bug
> Components: gobblin-service
> Reporter: Urmi Mustafi
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
> In a previous change, we noticed the compiled flowExecutionId was different
> from the one during execution and tried to fix it by updating the
> flowMetadata used to send GTE relating to compilation. We succeeded in
> updating the compilation event to use the flowExecutionId but did not update
> the FlowSpec used by Compiler to create the Dag which is used during the
> execution phase of flow management. The compiler retrieves a flowExecutionId
> if one exists in the flowSpec (which it does for adhoc flows), otherwise
> generates a new one
> ([code|[https://jarvis.corp.linkedin.com/codesearch/result/?name=MultiHopFlowCompiler.java&path=gobblin-elr%2Fgobblin-service%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fgobblin%2Fservice%2Fmodules%2Fflow&reponame=linkedin%2Fgobblin-elr#301]).]
> We do need to modify the FlowSpec then with the consensus flowExecutionId
> before forwarding it to the DagManager.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)