homatthew commented on code in PR #3843: URL: https://github.com/apache/gobblin/pull/3843#discussion_r1449727161
########## gobblin-metrics-libs/gobblin-metrics-base/src/main/java/org/apache/gobblin/metrics/event/EventSubmitter.java: ########## @@ -37,6 +53,8 @@ * </p> * */ +@JsonSerialize(using = EventSubmitter.Serializer.class) +@JsonDeserialize(using = EventSubmitter.Deserializer.class) Review Comment: Changed my mind. Going back to the POJO approach. The boiler plate is pretty much the same and the POJO makes it obvious some information may be lost -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
